4
5 Comments

Roast my GitHub app feedback

https://github.com/apps/rubocop-auto-fixer-ruby-ror

My first attempt at a GitHub App, please roast it ^^
Would also use some of this for a more generic page if it's any good.
It can already also work on GitLab as either a team member or external on open source.

The bigger benefit in my eyes is joining like 10 things into one... like a community linter, Dependency updater, Security checker, Code English Spelling checker
And the idea to only offer fixes not list warning and block PRs.

I do have too many directions in my head, hopefully releasing something for some feedback would help me focus

Thanks,

on October 15, 2020
  1. 1

    Is there pricing? Why not just use pre-commit hooks so PR reviewers can see the nicely formatted code for each feature?

    Comparing pre-commit hooks with your tools:

    • pre-commit means the PR reviewer only reviews nicely formatted code.
    • pre-commit keeps a usable git history / git blame. I hate it when I go to look when a line of code change last, it useless things like "rubocop removed whitespace - 1 mo ago", when the line practically hasn't changed in 6+ years.
    • As an app, someone has to review these style changes. If I see a PR with 1,500 updates I'm either not going to review it or just hope the style changes don't break something (which they definitely can). New PRs = time out of my day from doing something important.
    • pre-commit is free. I'm not sure your pricing.
    • pre-commit doesn't expose source code to unvetted 3rd parties.

    Lets say for whatever reason you don't wanna have a pre-commit hook. You could also setup github actions to run against new commits in a feature branch so the reviewer still sees nicely formatted code and the git history / blame is nice b/c the commits are associated with the PR.

  2. 1

    This comment was deleted 5 years ago

    1. 1

      Added a screenshot due I need to think what should be in there...
      Did you like the one you looked at? maybe I can use it for inspiration..

      1. 2

        This comment was deleted 5 years ago

    2. 1

      I'm just learning this stuff myself :P
      I've applied for the marketplace, basically that is manually reviewed. It seems they are in a review freeze without much context attached.

      1. 1

        This comment was deleted 5 years ago

        1. 1

          Yea, again that needs review
          And to be approved for paid, you need to get verified, which has corporate like docs required like how you handle security breaches... (the docs that you think, well I wake myself up, than let myself know, than my other self goes and look at it and he tells me to go press that thingy ^^.. :D :sweat-smile: )
          And it has a minimum user installations requirement.

          p.s. they take 25%

          1. 1

            This comment was deleted 5 years ago

            1. 2

              minimum user installations before you can be verified (I assume before you can submit)

              GitHub Apps should have a minimum of 100 installations.

              https://docs.github.com/en/free-pro-team@latest/developers/github-marketplace/requirements-for-listing-an-app

              On the app marketplace submit page they have
              "Reviews of verification requests are currently paused as we work to improve the process. For more details, see Listing on GitHub Marketplace."
              Link goes to https://docs.github.com/en/free-pro-team@latest/developers/github-marketplace/listing-an-app-on-github-marketplace

              That page separate review and verified, where review doesn't seem to have a minimum installations